Improve API documentation of banner, incubating, and spright components #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajsite
approved these changes
May 31, 2024
packages/storybook/src/nimble/rich-text-mention/users/rich-text-mention-users.stories.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Ongoing efforts towards #824. This PR covers the remaining components: banner, incubating components, and spright components.
After this completes all the components are done but there are still some cross-component consistency improvements described in a checklist on #824.
👩💻 Implementation
Following standard patterns from previous PRs: reorganizing MDX headings, adding categories to each parameter in the args table, and making language and naming more consistent.
For the rich text components I also migrated some content around to better fit our standard document structure.
🧪 Testing
Inspected built storybook.
✅ Checklist