Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Angular 17 #2174

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Update to Angular 17 #2174

merged 5 commits into from
Jul 22, 2024

Conversation

m-akinc
Copy link
Contributor

@m-akinc m-akinc commented Jun 7, 2024

Pull Request

🤨 Rationale

Trying to keep up with Angular releases.

👩‍💻 Implementation

  • updated package dependencies
  • updated one reference in the nimble-angular README.

🧪 Testing

Ran tests. Having SLE apps test against tgz of nimble-angular.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@m-akinc m-akinc marked this pull request as ready for review June 7, 2024 18:58
@rajsite rajsite marked this pull request as draft June 7, 2024 19:01
@m-akinc m-akinc marked this pull request as ready for review June 7, 2024 20:36
@m-akinc m-akinc requested a review from rajsite June 7, 2024 20:36
rajsite
rajsite requested changes Jun 7, 2024
View reviewed changes
Copy link
Member

@rajsite rajsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like the upgrade aligns to angular supported library versions

@m-akinc m-akinc requested a review from rajsite June 8, 2024 00:09
rajsite
rajsite reviewed Jun 12, 2024
View reviewed changes
Copy link
Member

@rajsite rajsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for merge conflicts to be resolved to see build log impacts

@m-akinc m-akinc requested a review from rajsite June 12, 2024 18:42
@rajsite
Copy link
Member

rajsite commented Jul 17, 2024

Moving to draft until ready to release train ready

@rajsite rajsite marked this pull request as draft July 17, 2024 17:10
@m-akinc m-akinc marked this pull request as ready for review July 18, 2024 17:01
@m-akinc m-akinc enabled auto-merge (squash) July 22, 2024 14:46
@m-akinc m-akinc merged commit f69586a into main Jul 22, 2024
13 checks passed
@m-akinc m-akinc deleted the users/makinc/angular17 branch July 22, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajsite rajsite rajsite approved these changes

@atmgrifter00 atmgrifter00 atmgrifter00 approved these changes

@jattasNI jattasNI jattasNI approved these changes

@TrevorKarjanis TrevorKarjanis TrevorKarjanis approved these changes

@fredvisser fredvisser Awaiting requested review from fredvisser fredvisser is a code owner

@vivinkrishna-ni vivinkrishna-ni Awaiting requested review from vivinkrishna-ni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@m-akinc @rajsite @TrevorKarjanis @jattasNI @atmgrifter00