HLD for adding error state to checkbox and radio group #2394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mollykreis
commented
Sep 11, 2024
packages/nimble-components/src/patterns/error/specs/checkbox-radio-error.md
Outdated
Show resolved
Hide resolved
|
@m-akinc, will you buddy this PR for me? |
m-akinc
reviewed
Sep 11, 2024
packages/nimble-components/src/patterns/error/specs/checkbox-radio-error.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/patterns/error/specs/checkbox-radio-error.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/patterns/error/specs/checkbox-radio-error.md
Outdated
Show resolved
Hide resolved
m-akinc
approved these changes
Sep 17, 2024
mollykreis
requested review from
rajsite,
jattasNI and
atmgrifter00
as code owners
atmgrifter00
approved these changes
Sep 17, 2024
jattasNI
approved these changes
Sep 18, 2024
packages/nimble-components/src/patterns/error/specs/checkbox-radio-error.md
Outdated
Show resolved
Hide resolved
rajsite
approved these changes
Sep 24, 2024
packages/nimble-components/src/patterns/error/specs/checkbox-radio-error.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/patterns/error/specs/checkbox-radio-error.md
Outdated
Show resolved
Hide resolved
packages/nimble-components/src/patterns/error/specs/checkbox-radio-error.md
Outdated
Show resolved
Hide resolved
jattasNI
approved these changes
Sep 30, 2024
rajsite
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
HLD for adding error state to checkbox and radio group
This is the HLD for #2018 and #2019
👩💻 Implementation
N/A
🧪 Testing
N/A
✅ Checklist