-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text field error spacing #2399
Merged
Merged
Text field error spacing #2399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@m-akinc, can you buddy this PR for me? |
m-akinc
approved these changes
Sep 19, 2024
mollykreis
commented
Sep 19, 2024
jattasNI
approved these changes
Sep 20, 2024
mollykreis
commented
Sep 20, 2024
rajsite
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Fixes #2090
There are a few problems with the spacing in the text field:
input
to the error icon, the innerinput
to theaction
slot buttons, and the error icon to theaction
slot buttons.action
slot buttons, or right edge of the innerinput
) is measured from the border rather than including the border.start
slot icon is 8px rather than 4px.start
slot icon or left edge of the innerinput
).This PR addresses problems 1 & 2 above, but it does not address problems 3-5 because these should be addressed across all components (select, combobox, number field, etc) in order to avoid creating misalignments of text across components. Therefore, I created #2400.
👩💻 Implementation
gap
used in the text-field to be small padding (4px) rather than medium padding (8px), which addressed problems 1 & 2.gap
, I also added 4px to the left padding of the.root
element.start
icon to keep the icon 8px from theinput
.🧪 Testing
✅ Checklist