Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable mention intermittent failed cases #2403

Merged
merged 11 commits into from
Oct 14, 2024
Merged

Re-enable mention intermittent failed cases #2403

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0efcac8
Re-enable mention intermittently failed test cases
aagash-ni Sep 19, 2024
c533f42
Change files
aagash-ni Sep 19, 2024
377842d
Merge branch 'main' into users/aagash/intermittent-mention-test
aagash-ni Sep 19, 2024
e4f7d66
Skip firefox
aagash-ni Sep 19, 2024
bdb2188
Merge branch 'users/aagash/intermittent-mention-test' of https://gith…
aagash-ni Sep 19, 2024
c691f00
Focus before click
vivinkrishna-ni Oct 3, 2024
aed3beb
Reuse the focus editor logic in the page object
vivinkrishna-ni Oct 4, 2024
5554518
Merge branch 'main' into users/aagash/intermittent-mention-test
vivinkrishna-ni Oct 4, 2024
9db5e67
Focus editor and wait when updating the content of the editor
vivinkrishna-ni Oct 10, 2024
e84f344
Merge branch 'main' into users/aagash/intermittent-mention-test
vivinkrishna-ni Oct 10, 2024
629a247
Fix lint
vivinkrishna-ni Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@ni-nimble-components-3798a360-e7c9-425c-b1b9-df4b1015ea4a.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Re-enable mention intermittently failed test cases",
"packageName": "@ni/nimble-components",
"email": "123377167+aagash-ni@users.noreply.github.com",
"dependentChangeType": "patch"
}
4 changes: 2 additions & 2 deletions packages/nimble-components/src/rich-text/editor/tests/rich-text-editor-mention.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1542,8 +1542,8 @@ describe('RichTextEditorMentionListbox', () => {
expect(pageObject.isMentionListboxOpened()).toBeTrue();
});

// Intermittent, see https://github.com/ni/nimble/issues/2219
xit('should show mention popup for multiple mention configuration elements', async () => {
// Firefox skipped, see https://github.com/ni/nimble/issues/2404
it('should show mention popup for multiple mention configuration elements #SkipFirefox', async () => {
rajsite marked this conversation as resolved.
Show resolved Hide resolved
await appendUserMentionConfiguration(element, [
{ key: 'user:1', displayName: 'username1' },
{ key: 'user:2', displayName: 'username2' }
Expand Down
4 changes: 2 additions & 2 deletions packages/nimble-components/src/rich-text/models/tests/markdown-serializer.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,8 +337,8 @@ Plain text 3`);
<user:1> `);
});

// Intermittent, see https://github.com/ni/nimble/issues/2219
xit('Mention node', async () => {
// Firefox skipped, see https://github.com/ni/nimble/issues/2404
it('Mention node #SkipFirefox', async () => {
await appendUserMentionConfiguration(element, [
{ key: 'user:1', displayName: 'username1' }
]);
Expand Down