Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CONTRIBUTING "Adding a new component" instructions #2422

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Improve CONTRIBUTING "Adding a new component" instructions #2422

merged 1 commit into from
Oct 1, 2024

Conversation

jattasNI
Copy link
Contributor

@jattasNI jattasNI commented Oct 1, 2024

Pull Request

🤨 Rationale

While preparing materials for an upcoming contribution I noticed our root CONTRIBUTING didn't clearly capture the important parts of our process.

👩‍💻 Implementation

Write better docs

🧪 Testing

N/A

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

jattasNI
jattasNI commented Oct 1, 2024
View reviewed changes
Copy link
Contributor Author

@jattasNI jattasNI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajsite this is just trivial doc updates so I'm planning to bypass you once the build finishes

@jattasNI jattasNI marked this pull request as ready for review October 1, 2024 15:18
@jattasNI jattasNI requested a review from rajsite as a code owner October 1, 2024 15:18
@rajsite rajsite merged commit 3862073 into main Oct 1, 2024
14 checks passed
@rajsite rajsite deleted the contributing-process branch October 1, 2024 15:39
@rajsite
Copy link
Member

rajsite commented Oct 1, 2024

@rajsite this is just trivial doc updates so I'm planning to bypass you once the build finishes

Beat you to it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajsite rajsite rajsite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jattasNI @rajsite