Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support error state on radio group in Angular and Blazor #2433

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Support error state on radio group in Angular and Blazor #2433

merged 5 commits into from
Oct 16, 2024

Conversation

mollykreis
Copy link
Contributor

Pull Request

🤨 Rationale

Resolves #2019 by adding Angular and Blazor support for error-text and error-visible on the nimble-radio-group.

👩‍💻 Implementation

  • Expose error text and error visible on the radio group in Angular and Blazor
  • Update Angular and Blazor example apps to put a label on the radio group

🧪 Testing

  • Updated unit tests for the components
  • Manually verified that error text and error visible can be configured through both Angular and Blazor

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@mollykreis
Copy link
Contributor Author

@atmgrifter00, will you buddy this PR for me?

@mollykreis mollykreis marked this pull request as ready for review October 16, 2024 19:38
@rajsite rajsite enabled auto-merge (squash) October 16, 2024 20:01
@rajsite rajsite merged commit 280d85a into main Oct 16, 2024
12 checks passed
@rajsite rajsite deleted the angular-blazor-radio-group-error-state branch October 16, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atmgrifter00 atmgrifter00 atmgrifter00 approved these changes

@msmithNI msmithNI msmithNI approved these changes

@rajsite rajsite rajsite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error state for nimble-radio-group
4 participants
@mollykreis @rajsite @msmithNI @atmgrifter00