Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin FAST foundation and element versions until new versions vetted #2455

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

m-akinc
Copy link
Contributor

@m-akinc m-akinc commented Oct 28, 2024

Pull Request

🤨 Rationale

Unit tests on Firefox seem to be sporadically timing out when we update to the latest exports of fast-foundation (2.50.0) and fast-element (1.14.0). We want to pin our dependency versions to the prior versions until we are confident that the new versions do not introduce real problems for clients.

👩‍💻 Implementation

Pinned fast-element to 1.13.0 and fast-foundation to 2.49.6 in the three packages that reference them.

🧪 Testing

N/A

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

Copy link
Member

@rajsite rajsite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Packages were incorrectly pinned to versions not in the lock file

@m-akinc m-akinc requested a review from rajsite October 28, 2024 20:02
@rajsite rajsite merged commit b83708f into main Oct 28, 2024
14 checks passed
@rajsite rajsite deleted the users/makinc/pin-fast-foundation branch October 28, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants