Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check spec timing on foundation update #2460

Closed
wants to merge 19 commits into from
Closed

Check spec timing on foundation update #2460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
94a7100
Update fast versions
rajsite Oct 24, 2024
6e3db76
Change files
rajsite Oct 24, 2024
6e621f9
No-op change to trigger build
m-akinc Oct 29, 2024
fdc0b9a
Re-trigger build
m-akinc Oct 30, 2024
e46c3ac
Merge branch 'main' into fast-foundation-update
rajsite Oct 30, 2024
3ced6f7
update lock from main (copy from main and npm install)
rajsite Oct 30, 2024
6265e3e
Update karma.conf.headless.js
rajsite Oct 30, 2024
7de3d2a
Update package.json
rajsite Oct 30, 2024
9536590
Update package.json
rajsite Oct 30, 2024
5098b9e
Increase jasmine timeout from 5s to 30s
rajsite Oct 30, 2024
ee45b4b
Report slow tests
rajsite Oct 30, 2024
7c3f37a
trigger rebuild
rajsite Oct 30, 2024
ff30e71
Update main.yml
rajsite Oct 30, 2024
21a066e
Update package.json
rajsite Oct 30, 2024
9a5e64a
Update package.json
rajsite Oct 30, 2024
5111148
Update karma.conf.headless.js
rajsite Oct 30, 2024
35961e7
retrigger build
rajsite Oct 30, 2024
8a62bce
Update package.json
rajsite Oct 31, 2024
346590d
Update package.json
rajsite Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ jobs:

# Validate (Lint and Test)
- run: npm run validate
- run: cat ./out.txt
working-directory: packages/nimble-components/

# Run Lighthouse audit (from any push)
- name: Performance Audit with Lighthouse CI
Expand Down
7 changes: 7 additions & 0 deletions change/@ni-nimble-components-05fac024-430c-46fd-86e3-987b72a3b15a.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update fast versions",
"packageName": "@ni/nimble-components",
"email": "rajsite@users.noreply.github.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@ni-spright-components-caea7f74-72de-42d8-a96d-b4288c46707d.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update fast versions",
"packageName": "@ni/spright-components",
"email": "rajsite@users.noreply.github.com",
"dependentChangeType": "patch"
}
38 changes: 19 additions & 19 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions packages/nimble-components/karma.conf.headless.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,11 @@ module.exports = config => {
plugins: [...config.plugins, 'karma-spec-reporter'],
reporters: ['spec'],
specReporter: {
suppressPassed: true,
suppressSkipped: false,
suppressPassed: false,
suppressSkipped: true,
showSpecTiming: true
}
},
reportSlowerThan: 1000
};

config.set(options);
Expand Down
8 changes: 4 additions & 4 deletions packages/nimble-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@ni/nimble-components",
"version": "32.6.0",
"description": "Styled web components for the NI Nimble Design System",
"description": "Styled web components for the NI Nimble Design System [trigger rebuild 7]",
"scripts": {
"build": "npm run generate-icons && npm run generate-workers && npm run build-components && npm run bundle-components && npm run generate-scss",
"lint-concurrent": "concurrently --pad-prefix --timings --group \"npm:eslint\" \"npm:prettier\"",
Expand Down Expand Up @@ -41,7 +41,7 @@
"test-webkit:debugger": "karma start karma.conf.js --browsers=WebkitDebugging --skip-tags SkipWebkit",
"test-webkit:watch": "karma start karma.conf.headless.js --browsers=WebkitHeadless --skip-tags SkipWebkit --watch-extensions js",
"test-webkit": "karma start karma.conf.headless.js --browsers=WebkitHeadless --single-run --skip-tags SkipWebkit",
"test-concurrent": "concurrently --pad-prefix --timings --group \"npm:test-chrome\" \"npm:test-firefox\" \"npm:test-webkit\""
"test-concurrent": "concurrently --pad-prefix --timings --group \"npm:test-chrome\" \"npm:test-firefox\" \"npm:test-webkit\" | tee -a out.txt"
},
"repository": {
"type": "git",
Expand All @@ -60,8 +60,8 @@
"homepage": "https://github.com/ni/nimble#readme",
"dependencies": {
"@microsoft/fast-colors": "^5.3.1",
"@microsoft/fast-element": "1.13.0",
"@microsoft/fast-foundation": "2.49.6",
"@microsoft/fast-element": "^1.14.0",
"@microsoft/fast-foundation": "^2.50.0",
"@microsoft/fast-web-utilities": "^6.0.0",
"@ni/nimble-tokens": "^8.4.0",
"@tanstack/table-core": "^8.19.3",
Expand Down
1 change: 1 addition & 0 deletions packages/nimble-components/src/utilities/tests/setup-configuration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@
console.error = (data: any): void => fail(data);
// eslint-disable-next-line no-console, @typescript-eslint/no-explicit-any
console.warn = (data: any): void => fail(data);
jasmine.DEFAULT_TIMEOUT_INTERVAL = 30000;
4 changes: 2 additions & 2 deletions packages/spright-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@
},
"homepage": "https://github.com/ni/nimble#readme",
"dependencies": {
"@microsoft/fast-element": "1.13.0",
"@microsoft/fast-foundation": "2.49.6",
"@microsoft/fast-element": "^1.14.0",
"@microsoft/fast-foundation": "^2.50.0",
"@ni/nimble-components": "^32.6.0",
"tslib": "^2.2.0"
},
Expand Down
6 changes: 3 additions & 3 deletions packages/storybook/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
},
"devDependencies": {
"@chromatic-com/storybook": "^2.0.2",
"@microsoft/fast-element": "1.13.0",
"@microsoft/fast-foundation": "2.49.6",
"@microsoft/fast-react-wrapper": "^0.3.22",
"@microsoft/fast-element": "^1.14.0",
"@microsoft/fast-foundation": "^2.50.0",
"@microsoft/fast-react-wrapper": "^0.3.25",
"@microsoft/fast-web-utilities": "^6.0.0",
"@ni/nimble-components": "*",
"@ni/spright-components": "*",
Expand Down