Run pyupgrade to update Python syntax used #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ividual files:
- Use fstrings where reasonable
- replace use of really old % format specifier
- removal of coding: utf-8 comment (it's the default encoding)
- drop unnecessary Object argument from base class declarations
- delete leading u from unicode-literals (python 3 strings support unicode characters)
- delete unnecessary index arguments to {} for strings where we continue to use .format
- pyupgrade is timid about f-string usage in order to maintain short and readable code
- Use dict comprehension rather than whatever we were doing in nifake/unit_tests/test_grpc.py
- delete unnecessary arguments from open() calls
- Use set comprehension in metadata_add_all.py
Discarded changes to test_converters.py. I believe we're not passing the right arguments for some tuple tests
In addition to reflecting the changes in the previous commit, the copyright date in conf.py was updated to include 2024.
|
I considered cleaning up some of the remaining .format() calls, but decided to leave this as only automated changes. |
|
pyupgrade can be used as a pre-commit hook, but I don't think that would be a good idea, given that it broke the indentation of some of our templates. |
marcoskirsch
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution adheres to CONTRIBUTING.md.
[ ] I've updated CHANGELOG.md if applicable.[ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Note: No hand-coded changes are included.
Using a script, I ran
pyupgrade --py38-pluson files in nimi-python. pyupgrade is a tool used to automatically update the syntax used in Python code to syntaxes available in newer versions.The script ran on the following folders:
The script ignored folder paths containing:
__pycache__The script ignored files with the extensions:
The script ignored imported metadata files (the ones that say they were generated) as well as "fancy_fetch_capture_waveform.py.mako" (pyupgrade messed up the indentation) and "_get_error_description.py.mako" (pyupgrade messed up the indentation).
List of automatic changes that I noticed:
I discarded changes to test_converters.py. I believe we're not passing the right arguments for some tuple tests, so I want to handle that separately.
List issues fixed by this Pull Request below, if any.
None
What testing has been done?