Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overwrite example testing results #2048

Merged

Conversation

ni-jfitzger
Copy link
Collaborator

  • This contribution adheres to CONTRIBUTING.md.
  • [ ] I've updated CHANGELOG.md if applicable.
  • [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Stop creating the unused kibana jsons
  • Assign a different junitxml name to example test results, so they are not overwrriten by system test results
    • junitxmls are only used by our internal test suites

List issues fixed by this Pull Request below, if any.

What testing has been done?

  • Ran the system tests on a local machine for niswitch.
    • Confirmed that results were being overwritten
    • Confirmed that the changes produce 2 seprate test result files, so nothing is overwritten

@ni-jfitzger
Copy link
Collaborator Author

I wasn't originally going to do this for this release, but I wrapped up my committed work this weekend and had some time. Testing changes have to make it into a release to take effect in our internal suites.

@marcoskirsch marcoskirsch merged commit 72fce1e into ni:master Apr 22, 2024
35 checks passed
@ni-jfitzger ni-jfitzger deleted the do-not-overwrite-example-testing-results branch April 22, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal Test Suites do not report results of example testing
2 participants