Skip to content

Install numpy as part of installer for modules using numpy parameters#2170

Merged
vnktshr21 merged 3 commits intoni:masterfrom
rahur-NI:InstallNumpyAlongWithNirfsgInstaller
Mar 18, 2026
Merged

Install numpy as part of installer for modules using numpy parameters#2170
vnktshr21 merged 3 commits intoni:masterfrom
rahur-NI:InstallNumpyAlongWithNirfsgInstaller

Conversation

@rahur-NI
Copy link
Contributor

@rahur-NI rahur-NI commented Mar 17, 2026

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

For modules like nirfsg, methods like write_arb_waveform which deal with complex datatypes, accepts only numpy datatypes as inputs. This PR updates setup.py.mako template to install numpy as an install dependency for any module that uses complex datatype parameters.

List issues fixed by this Pull Request below, if any.

  • run_examples_using_pypi_uploads action was failing for nirfsg because we were not installing numpy. We need not specify numpy for nirfsg anyways going forward since it becomes a package dependency.

What testing has been done?

  • Ensured the setup.py files of modules which uses numpy is updated.
  • Verified that nirfsg package install is installing numpy.

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.98%. Comparing base (f6256a0) to head (c55b7e2).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2170   +/-   ##
=======================================
  Coverage   89.98%   89.98%           
=======================================
  Files          71       71           
  Lines       18711    18711           
=======================================
+ Hits        16837    16838    +1     
+ Misses       1874     1873    -1     
Flag Coverage Δ
codegenunittests 84.90% <ø> (ø)
nidcpowersystemtests 94.65% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.26% <ø> (ø)
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 92.72% <ø> (ø)
nifakeunittests 85.68% <ø> (ø)
nifgensystemtests 94.61% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsgsystemtests 81.30% <ø> (ø)
niscopesystemtests 92.94% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 82.03% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6256a0...c55b7e2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rahur-NI rahur-NI marked this pull request as ready for review March 17, 2026 12:34
@vnktshr21 vnktshr21 merged commit c328bc3 into ni:master Mar 18, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants