Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2170 +/- ##
=======================================
Coverage 89.98% 89.98%
=======================================
Files 71 71
Lines 18711 18711
=======================================
+ Hits 16837 16838 +1
+ Misses 1874 1873 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ni-jfitzger
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
For modules like nirfsg, methods like
write_arb_waveformwhich deal with complex datatypes, accepts only numpy datatypes as inputs. This PR updates setup.py.mako template to install numpy as an install dependency for any module that uses complex datatype parameters.List issues fixed by this Pull Request below, if any.
run_examples_using_pypi_uploadsaction was failing for nirfsg because we were not installing numpy. We need not specify numpy for nirfsg anyways going forward since it becomes a package dependency.What testing has been done?