Closed
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
web_apps/Framework_Examples/React/amur-react-vite-app/src/demo_config.ts
Outdated
Show resolved
Hide resolved
jattasNI
requested changes
Feb 4, 2026
| @@ -1,4 +1,4 @@ | |||
| # SystemLink Enterprise Examples | |||
| # SystemLink Enterprise Examples - BYU team Branch | |||
Collaborator
There was a problem hiding this comment.
Congrats on the milestone of creating a PR! We'll need to iterate on this to get it to the point where it's ready to submit. Here's some high-level feedback to start with. We can talk more about it at our next meeting or you can ask follow ups here / in Teams.
- PRs should have clear titles and descriptions to help reviewers understand what's being included and to keep the repo's git history as informative as possible. Include links to related issues that the PR is resolving / making progress on. You can look at other recent PRs to this repo for examples (feat: Add example notebook for Asset Calibration alarms and notification #68)
- PRs should deliver small increments of value to help reduce the amount of time they take to review and to improve the incremental velocity of contributions. At a minimum we should split out the React and Blazor changes into separate PRs but if there are other ways you can think of to reduce the PR size even further, please do so.
- PRs should have a clean directory structure of only source files. It looks like this one includes some build output and generated README stuff and includes some paths that include your names and some files refer to BYU branches
- It's best to do a self-review and a peer-review of the PR first before moving it out of the Draft state and adding code owners. Self review means that you look through the files and make sure it makes sense. Peer review means having others from the dev team look at it and provide their feedback. That helps streamline the amount of feedback that owners like me will need to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merged React and Blazer