Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary formatter fixes #131

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

shivaprasad-basavaraj
Copy link

This pull request has fixes to the WebVI examples to address the WebVI breakages resulting from fixes to address the Binary formatter security vulnerability reported in G Web Development Software.

@@ -1,13 +1,13 @@
<?xml version="1.0" encoding="utf-8"?>
<SourceFile Checksum="D44EAAD35630DF8AD90ABC00F32B4A9686839CE67C1AC04BD9F2F5BF8F03F37099483AC24047844B9F3FC57D977F037CEC43715A281BABB0B0177AEE564137C0" Timestamp="1D6BD2CCC3743BD" xmlns="http://www.ni.com/PlatformFramework">
<SourceFile Checksum="E016C368BE44CC42C3AA47DC7A5340EBD4C0947DD267A0079352081A519A4447F1D9549B9C3640F4E05B5C1A4BFBE3687B31806DD98DB89242F3AE6B8B515065" Timestamp="1DADC41474E3771" xmlns="http://www.ni.com/PlatformFramework">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating a comment to prevent accidental merging before we are ready

@rajsite
Copy link
Member

rajsite commented Nov 7, 2024

Pushed the following changes directly to this PR branch:

  • Reverted the gwebprojectcache changes. The only reason those files are there is so that the correct top-level gvis are open when the project is open. I found when I opened any gwebproject in your branch that the gwebprojectcache files would be dirty again. It didn't make sense to update them every time. I reverted them back to what is is main and tested that the projects open correctly
  • I removed all references to SystemLink Cloud in the examples (pretty much just the SystemLink example)
  • In validating the Systemlink example I fixed two issues, one with error handling and one with excessive updates to the slider
  • I did not update the README text. That can be done later and is not included in product anyway. The READMEs are only used on GitHub.

If you validate that all the changes look good @shivaprasad-basavaraj then we are ready 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants