Feat/use security hub severity levels #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the config rule name and its identifier didn't match. This is necessary because the Security Hub controls use the rule name, not its identifier, in the documentation.
…e overrides replace severities set by Security Hub and are maintained manually.
…gs from internal teams
yangx17
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, new Config Rules are added with a
Mediumseverity by default because AWS doesn't set severity levels for the rules themselves. However, AWS Security Hub does maintain a list of security controls and standards that reference Config Rules, and that list does include severity levels for the corresponding rules. It's possible that setting a rule severity toMediumby default masks the suggested severity set by the Security Hub controls.This PR scrapes the Security Hub controls references and matches the severities to the appropriate rules. A new list of rules and severities is generated when the automation is run so any severities set manually are overwritten. The changes here are a result of running the updated scripts.