Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rule overrides #48

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Fix rule overrides #48

merged 2 commits into from
Jun 14, 2024

Conversation

bensonce
Copy link
Contributor

@bensonce bensonce commented Jun 13, 2024

Fixed an issue where the new identifier attribute was being lost in the merge between managed rules config and overrides provided by the user. Now, a user doesn't need to provide values for all attributes when overriding rule config.

Fixes #48

… merge between managed rules config and overrides provided by the user
@bensonce bensonce self-assigned this Jun 13, 2024
@bensonce bensonce added the bug Something isn't working label Jun 13, 2024
@bensonce bensonce merged commit 7f0bef1 into main Jun 14, 2024
5 of 6 checks passed
@bensonce bensonce deleted the b/fix-rule-overrides branch June 14, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants