Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/updating metabase to v0.38 #2

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Commits on Mar 26, 2021

  1. Update MS SQL Server JDBC driver version (metabase#15287)

    Bump mssql-jdbc version from 7.4.1.jre8 to 9.2.1.jre8
    
    Bump plugin version accordingly
    
    Override prepared-statement and statement multimethods for :sqlserver to not set holdability at the statement level
    
    Fixing inaccurate log statements
    jeff303 authored Mar 26, 2021
    Configuration menu
    Copy the full SHA
    d6765a1 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2021

  1. Configuration menu
    Copy the full SHA
    922b903 View commit details
    Browse the repository at this point in the history
  2. Check to see if done button is enabled whenever custom expr changes (

    …metabase#15293)
    
    This is done by firing an event on change which mutates if blankness of the input changes
    howonlee authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    bc92d8c View commit details
    Browse the repository at this point in the history
  3. Add CollapseSection UI component (metabase#15358)

    * Add CollapseSection component
    
    * Replace header string prop with header node prop
    
    * update nounage open/closed --> expanded/collapsed
    
    * add className prop
    daltojohnso authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    f7bb82d View commit details
    Browse the repository at this point in the history
  4. add string/number operator subtypes to dashboard parameter filters (m…

    …etabase#15068)
    
    * Remove location sub-categories
    
    These sub-categories are only for filtering the list of options
    when mapping a parameter filter to a field. Since we are introducing
    operator types as a sub-category of location, city/zip/etc. just get in
    the way.
    
    * add number section + number/string operator subtypes
    
    Light refactor of meta/Dashboard changes
    
    rmv 'all-options' options (for now)
    
    * add/update parameter type icons
    
    * pass operator to ParameterFieldWidget + show input per operator field
    
    * Add operator helper fns that aren't dependent on fields/tables
    
    * Make operator prop optional
    
    fix date filter err
    
    * add combined  name for native question filter widget type list
    
    Otherwise, a field that matches both "Location" and "Category"
    options will show duplicate "Starts with" options, etc. Now,
    that'll look like "Category - Starts with" and "Location - Starts with"
    
    * correct some unused prop/arg passing
    
    * Convert location/category parameter types to string for query
    
    location/category don't mean anything to BE but we use them for
    "reasons" on the FE. Reasons are legacy reliance on unique-ness of
    the parameter.type value, primarily.
    
    * operators in backend
    
    * Remove errant tap>
    
    * Docstrings and differing numbers in tests in some dbs
    
    * Make unary private so docstring checker ~shuts-up~ is satisfied
    
    * Don't parse arguments to operators params
    
    they were coming in just fine from the FE as numeric or string
    types. no need to ensure strings everywhere and parse here
    
    * add max-width to PopoverPicker
    
    * rmv unused value
    
    * use combinedName on dashboard parameters
    
    * fix parameter to mbql code
    
    * Ensure = operator filter popovers have no label
    
    This is to match "old" style of parameter popover
    
    * Update Cypress tests to reflect new parameter flow
    
    fix cypress dashboard parameter tests
    
    Fix more cy tests
    
    * Don't call fk/joinAlias on ExpressionDimension
    
    The methods don't exist on ExpressionDimension class.
    
    This doesn't make them work (yet), but it prevents the app
    from crashing.
    
    * Namespace doc and remove unnecessary comment
    
    * tap>-spy in dev
    
    * first pass at substitution of new operators in native
    
    * Docstring on wrap-value-literals-in-mbql to appease the gods
    
    * variadic equality operators (string/= number/=)
    
    * move functions out of component file
    
    * Pass parameter object to tag editor for use in default input
    
    We should inline this input eventually because it looks ugly.
    
    * map parameters in Questions to correct type
    
    * continue to pass janky fake parameter for text/number tags
    
    * mongo native substitution
    
    * variadic not-equals for string and number
    
    * Docstring and use correct function to make errors
    
    * add number/between dash param cy test
    
    * Update function name to better reflect behavior
    
    * Add unit tests for paramer/operator util fns
    
    add unit tests for parameter util functions
    
    add unit test for operator util fns
    
    * add variadic string 'is not' param operator option
    
    * Modify operator parameter display labels
    
    don't append 'matches exactly' to location/category parameters
    
    label tweaks
    
    Update cy tests to reference correct label name
    
    rmv it.only
    
    * Desugar mongo parameters mbql
    
    desugaring makes for a bit more verbose query but that's ok.This
    change was done to ensure that we negated regexes in a correct way,
    and to do so we always return the string version. This ensures that it
    can be json/generate-string'd for native parameters or left as
    datastructures and sent to monger
    
    * Cleanup stale comments and fixup docstring for consistency
    
    * Arglists metadata on defmulti and denude some threaded forms
    
    * add single arity number tag predicate to variable filter
    
    * add Location operators to fix parameter<->filter mapping
    
    For question filters to work we need for the new parameter operators
    to be supported by "location" fields in all areas of the app.
    
    * Don't show coords for param number widgets
    
    I don't think we want to support all the various number operators when
    dealing with coordinates, so in order to avoid that I'm preventing the
    mapping of number parameter operator to coord fields.
    
    * prevent mapping of tags to non-equal operators
    
    while possibly useful to end users, this needs more UI work on the
    native question side of things.
    
    * Ensure parameter values are wrapped in an array
    
    When an = operator is mapped to a field AND a tag, it ends up not being
    wrapped in an array due to the TextWidget (I think).
    
    ensure parameter value is an array
    
    ensure number params have an array value
    
    * Sort imports correctly
    
    clojure-lsp used to do this incorrectly (sorting `[` before `j`) and
    that has now been fixed
    
    Co-authored-by: dan sutton <dan@dpsutton.com>
    daltojohnso and dpsutton authored Mar 29, 2021
    Configuration menu
    Copy the full SHA
    f10e9cf View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Configuration menu
    Copy the full SHA
    795c172 View commit details
    Browse the repository at this point in the history
  2. RIP Expectations tests 2015-2021 (No more old-style tests) (metabase#…

    …15313)
    
    * No more old-style tests
    
    * Presto test fix 🔧
    camsaul authored Mar 30, 2021
    Configuration menu
    Copy the full SHA
    8014d51 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'master' of https://github.com/metabase/metabase into im…

    …provement/updating-metabase-to-v0.38
    Gabriel Sampaio Bur committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    047a49e View commit details
    Browse the repository at this point in the history