secret as parameter and docs

nichlaes · Oct 31, 2024 · 2303973 · 2303973
1 parent bf8422a
commit 2303973
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/.github/workflows/lib-ms.yml b/.github/workflows/lib-ms.yml
@@ -142,7 +142,8 @@ jobs:
       node-version: ${{ needs.get_version.outputs.node-version }}
       registry-url: 'https://npm.pkg.github.com/'
       directory: servers/lib
-    secrets: inherit
+    secrets:
+      NPM_TOKEN: ${{ secrets.NPM_GITHUB_TOKEN }}
 
   publish-package-npm:
     if: | 
@@ -155,7 +156,8 @@ jobs:
       node-version: ${{ needs.get_version.outputs.node-version }}
       registry-url: 'https://registry.npmjs.org'
       directory: servers/lib
-    secrets: inherit
+    secrets:
+      NPM_TOKEN: ${{ secrets.NPM_TOKEN}}
 
   publish-docker-image-ghcr:
     if: | 

diff --git a/.github/workflows/publish-npm.yml b/.github/workflows/publish-npm.yml
@@ -15,9 +15,9 @@ on:
    package-name:
     default: ''
     type: string
-
-env:
-  NODE_VERSION: 20
+  secrets:
+    NPM_TOKEN:
+      required: true
 
 jobs:
   publish-package:
@@ -36,7 +36,7 @@ jobs:
       - name: Setup node
         uses: actions/setup-node@v4
         with:
-          node-version: ${{ env.NODE_VERSION }}
+          node-version: ${{ inputs.node-version }}
           always-auth: true
           registry-url: ${{ inputs.registry-url }}
 

diff --git a/docs/developer/github-actions.md b/docs/developer/github-actions.md
@@ -8,7 +8,9 @@ from [docker hub](hub.docker.com):
 | `DOCKERHUB_SCOPE` | Username or organization name on docker hub |
 | `DOCKERHUB_USERNAME` | Username on docker hub |
 | `DOCKERHUB_TOKEN` | API token to publish images to docker hub, with `Read`, `Write` and `Delete` permissions |
+| `NPM_TOKEN` | Token to publish npm package to Nodejs registry. |
+| `NPM_GITHUB_TOKEN` | Token to publish npm package to Github registry |
 
 Remember to add these secrets to
 [Github Secrets Setting](https://docs.github.com/en/actions/security-for-github-actions/security-guides/using-secrets-in-github-actions#creating-secrets-for-a-repository)
-of your fork.
+of your fork.