wip: Implement journal support #358
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
changed the title
nicholasbishop
force-pushed
the
bishop-journal-3
branch
5 times, most recently
from
008ceeb to
3db9cf5
Compare
nicholasbishop
force-pushed
the
bishop-journal-3
branch
4 times, most recently
from
7b4bda4 to
f4fab76
Compare
nicholasbishop
force-pushed
the
bishop-journal-3
branch
8 times, most recently
from
ecded87 to
8d74537
Compare
nicholasbishop
force-pushed
the
bishop-journal-3
branch
7 times, most recently
from
0b995a9 to
79e1dee
Compare
The interesting change is in error.rs, changing all of the `/// Inode number.` fields to use the `InodeIndex` type. Also removed inner docstrings from those fields, since the type name is sufficiently clear. The rest of the changes are mechanical compile/lint fixes.
This is `expect(unused)` until more of the journal code is added.
nicholasbishop
force-pushed
the
bishop-journal-3
branch
from
79e1dee to
7800b72
Compare
nicholasbishop
force-pushed
the
bishop-journal-3
branch
from
7800b72 to
f3386ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.