fix(provider): terminate job before closing terminal to prevent orphaned processes

[pedropombeiro]

Summary

When Neovim exits, the opencode --port process stays orphaned in memory instead of being terminated.

Root Cause

During VimLeavePre, snacks.terminal has already cleaned up its internal state, which invalidates the Neovim job. This means:

• jobstop(job_id) returns true but doesn't actually terminate the process
• jobpid(job_id) returns nil - Neovim no longer knows which PID the job maps to

Solution

Capture the PID (not just job ID) when the terminal opens, and use shell kill to terminate it directly during VimLeavePre. This bypasses Neovim's job tracking entirely.

Changes

• snacks provider: Track _pid at toggle/start time using jobpid(terminal_job_id)
• snacks provider: Use vim.fn.system('kill -TERM ' .. pid) in stop() for reliable termination
• plugin/provider.lua: Change autocmd from VimLeave to VimLeavePre for earlier cleanup

Testing

1. Start opencode via :Opencode
2. Exit Neovim (:qa)
3. Verify no orphaned processes: ps aux | grep "opencode --port" should return nothing

[nickjvandyke]

Thanks for taking a crack at this!

Is it possible to stop the job and all its children too? The child process (opencode) seems to stick around for me. Not sure if this is specific to fish.

[pedropombeiro]

Thanks for taking a crack at this!

Is it possible to stop the job and all its children too? The child process (opencode) seems to stick around for me. Not sure if this is specific to fish.

Can you try again with the latest version?