Open
Conversation
added 4 commits
January 10, 2017 16:05
…72bcfa41fc88ca7'" because the repo has no tags. Use --always to give the hash in that case.
…umn being wrapped (the colon didn't fit in the line anymore). We now try to actually use Courier's size for some of the calculations instead of hardcoded magic numbers, but we should revisit this code.
nickshanks
reviewed
Jan 11, 2017
|
|
||
| // run panel | ||
| int button = [super runModalOpenPanel:openPanel forTypes:extensions]; | ||
| int button = [super runModalOpenPanel:openPanel forTypes:nil/*extensions*/]; |
nickshanks
reviewed
Jan 11, 2017
| NSDictionary *dictionary = [NSDictionary dictionaryWithObject:paragraph forKey:NSParagraphStyleAttributeName]; | ||
|
|
||
| NSMutableParagraphStyle *hexParagraph = [[NSParagraphStyle defaultParagraphStyle] mutableCopy]; | ||
| //[hexParagraph setLineBreakMode:NSLineBreakByCharWrapping]; |
Owner
There was a problem hiding this comment.
can you remove this line too? if it wraps at all, the next line gets screwed up, so we'd never uncomment it
nickshanks
reviewed
Jan 11, 2017
Owner
nickshanks
left a comment
nickshanks
left a comment
There was a problem hiding this comment.
we should add some tags :-)
| @@ -274,8 +274,6 @@ - (NSGradient *)gradientWithAlpha:(CGFloat)alpha | |||
| @implementation NSOpenGLContext (CGLContextAccess) | |||
| - (CGLContextObj)cglContext; | |||
Owner
There was a problem hiding this comment.
This whole function is redundant if the app won't compile on 10.2 (which it doesn't any more) — just delete it
…macos-10-12-fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few minimal fixes needed to make this build & generally work on 10.12.