Skip to content

Viatskova Katia #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vinter-mach wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Viatskova Katia #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions Reviews/Viatskova Katia
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
Хай

Короче я пыталась это сделать по-умному всеми силами, но теперь тут есть только это

1) Имхо стоит бить код на логические блоки. То есть разделять let\do с помощью бек спейсов. То же самое разделять поля и функции

2) Drawer.jack 49-54
do OutputExtensions.cleanChars(2, 56, 6);
do Output.moveCursor(2, 56);
do Output.printInt(x);
do OutputExtensions.cleanChars(4, 56, 6);
do Output.moveCursor(4, 56);
do Output.printInt(y);
имхо можно вынести в отдельный метод, аналогично

DrawerGame.jack 28-37
do Output.moveCursor(2, 50);
do Output.printString(messageX);
do Output.moveCursor(2, 56);
do Output.printString("0");
do Output.moveCursor(4, 50);
do Output.printString(messageY);
do Output.moveCursor(4, 56);
do Output.printString("0");
do Output.moveCursor(7, 50);
do Output.printString(messageType);

3) В остальном круто. Осмысленные названия и разбиение на функции и файлы, все оч чисто и прикольно