Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds check for empty thousands separator #1089

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kjeldahl
Copy link

A check is added for empty thousands separator so it is possible to render numbers without a thousands separator
#914

A check is added for empty thousands seperator so it is possible to render numbers without a thoudsands seperator
@kjeldahl
Copy link
Author

@nicolaskruchten I was unable to compile and test the patch due to some node setup issues.

@co-operate
Copy link

+1
Had the same issue, came to the same solution. In pivot.js this will result in:

if (thousandsSep) {
  while (rgx.test(x1)) {
    x1 = x1.replace(rgx, '$1' + thousandsSep + '$2');
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants