Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SepWriter.Header with Add methods for predefining header #124

Merged
merged 9 commits into from
Apr 15, 2024

Conversation

nietras
Copy link
Owner

@nietras nietras commented Apr 10, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 81.57895% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 98.84%. Comparing base (c2f1e99) to head (529b3fa).
Report is 5 commits behind head on main.

❗ Current head 529b3fa differs from pull request most recent head de1ffc9. Consider uploading reports for the commit de1ffc9 to get more accurate results

Files Patch % Lines
src/Sep/SepWriterHeader.cs 62.96% 10 Missing ⚠️
src/Sep/Internals/SepThrow.cs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   99.28%   98.84%   -0.44%     
==========================================
  Files          46       47       +1     
  Lines        3343     3386      +43     
  Branches      355      363       +8     
==========================================
+ Hits         3319     3347      +28     
- Misses         21       36      +15     
  Partials        3        3              
Flag Coverage Δ
Debug 98.16% <78.94%> (-0.52%) ⬇️
Release 98.72% <80.00%> (-0.42%) ⬇️
macos-latest 98.43% <78.94%> (+3.04%) ⬆️
ubuntu-latest 98.43% <78.94%> (-0.46%) ⬇️
windows-latest 98.16% <78.94%> (-0.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nietras nietras merged commit 4607239 into main Apr 15, 2024
28 checks passed
@nietras nietras deleted the writer-header-add branch April 15, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants