Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove net7.0 target #218

Merged
merged 2 commits into from
Jan 12, 2025
Merged

Remove net7.0 target #218

merged 2 commits into from
Jan 12, 2025

Conversation

nietras
Copy link
Owner

@nietras nietras commented Jan 12, 2025

Upcoming changes/refactorings will require using UnsafeAccessor to make SepWriter simpler and more efficient which is only available in net8.0+ so dropping .NET 7 support. If any users of Sep have an issue with this please chime in in this PR and why can't upgrade to .NET 8 or similar.

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (b0a2c59) to head (fa2107e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #218   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files          47       47           
  Lines        3602     3602           
  Branches      403      403           
=======================================
  Hits         3587     3587           
  Misses         13       13           
  Partials        2        2           
Flag Coverage Δ
Debug 99.41% <ø> (ø)
Release 99.84% <ø> (ø)
macos-latest 92.00% <ø> (-0.20%) ⬇️
ubuntu-latest 99.84% <ø> (+0.28%) ⬆️
windows-latest 99.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nietras nietras merged commit accd807 into main Jan 12, 2025
35 checks passed
@nietras nietras deleted the remove-net7.0 branch January 12, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant