Don't do online testing when smoking

nigelhorne · Sep 4, 2024 · 17efc9a · 17efc9a
1 parent 56c9a52
commit 17efc9a
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/Makefile.PL b/Makefile.PL
@@ -84,15 +84,13 @@ WriteMakefile(
 
 sub are_online
 {
-	return 0 if($ENV{'NO_NETWORK_TESTING'} || $ENV{'TRAVIS_PERL_VERSION'});
-	return 0 if(!-t STDIN);
+	return 0 if($ENV{'NO_NETWORK_TESTING'} || $ENV{'TRAVIS_PERL_VERSION'}) || $ENV{'AUTOMATED_TESTING'} || (!-t STDIN);
 
-	my $s = IO::Socket::INET->new(
+	if(my $s = IO::Socket::INET->new(
 		PeerAddr => 'openstreetmap.org:443',
 		Timeout => 10
-	);
-	if($s) {
-		if($ENV{'PERL_MM_USE_DEFAULT'} || $ENV{'AUTOMATED_TESTING'}) {
+	))  {
+		if($ENV{'PERL_MM_USE_DEFAULT'}) {
 			close($s);
 			return 0;
 		}