Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix viewing older versions #802

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Fix viewing older versions #802

merged 2 commits into from
Mar 13, 2024

Conversation

egauzens
Copy link
Contributor

Description

Bug fix when viewing older versions of computational models. We were missing a check which was resulting in only the most recent version being shown

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Locally

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have utilized components from the Design System Library where applicable
  • I have added or updated unit tests that prove my fix is effective or that my feature works
  • I updated any relevant QC tests to match my changes found here: https://docs.google.com/document/d/1tlV89PMOv8XlmC7LVqifi7NfQ5-AYN8DuEQpmO7O_2Q

Copy link

cypress bot commented Mar 13, 2024

1 failed test on run #54 ↗︎

1 46 4 0 Flakiness 0

Details:

removed unnecessary =
Project: SPARC Portal E2E testing Commit: 4c71c4be4a
Status: Failed Duration: 08:45 💡
Started: Mar 13, 2024 4:34 PM Ended: Mar 13, 2024 4:43 PM
Failed  test/cypress/e2e/homepage.cy.js • 1 failed test

View Output Video

Test Artifacts
Homepage > Footer Screenshots Video

Review all test suite changes for PR #802 ↗︎

@egauzens egauzens merged commit 1ae1787 into master Mar 13, 2024
0 of 2 checks passed
@egauzens egauzens deleted the fix-viewing-older-versions branch March 13, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants