feat(service): PagerDuty service integration #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikoksr
requested changes
Jan 12, 2025
There was a problem hiding this comment.
Hi @tecnologer, thank you for your PR, impressive stuff!
Minimal nitpicks really. Ready to merge once you fixed those.
I think
golangci-lint run --fix ./service/pagerdutyshould automatically do most of the work for you by fixing almost all linter complaints.
Cheers :)
nikoksr
reviewed
Jan 12, 2025
|
done, linter's complaints fixed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #933 +/- ##
===========================================
- Coverage 74.10% 31.69% -42.42%
===========================================
Files 44 63 +19
Lines 1572 2726 +1154
===========================================
- Hits 1165 864 -301
- Misses 307 1741 +1434
- Partials 100 121 +21 ☔ View full report in Codecov by Sentry. |
|
@tecnologer Hm, looks like the linter is still failing. I checked locally and golangci-lint run --fix ./service/pagerdutyremoves the two problematic comments no problem. |
nikoksr
approved these changes
Jan 15, 2025
|
@tecnologer merging! Thanks for your contribution again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PagerDuty integration as a notify service.
Motivation and Context
We implemented it for internal usage at DefectDojo and decided to contribute to the community.
How Has This Been Tested?
Unit tests for exported methods, test mock the client, and a proof of concept in a separate test project.
Screenshots / Output (if appropriate):
Types of changes
Checklist: