-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add io.SeekEnd support #16
Conversation
Signed-off-by: yxxhero <11087727+yxxhero@users.noreply.github.com>
@nikolaydubina should I fix the test error? I saw all the past PRs. all failed. |
hey, thanks for pointing this out! I think io.SeekEnd does not mean we are jumping to end of reader. instead, it means that we are counting offset relatively to the end of reader. this means, we have to consider offset. https://pkg.go.dev/io#SeekEnd other discussions on mechanics also, we need test for this. do you mind to add test for this behavior as well? (I just broken tests due to security leak of my AWS tokens, so if you figure out how to use anonymous credentials: https://pkg.go.dev/github.com/aws/aws-sdk-go/aws/credentials#AnonymousCredentials + some public file, file used now should also be public, but if you find better file it is also good :) ) |
past PRs failed mostly because of Dependabot. I configured both A) Dependabot and B) approved GitHub Actions to use my same AWS tokens. but this is not good. I dropped my tokens now. we need to use anonymous credentials for this pipeline. |
@nikolaydubina updated. please see the logic. if it's ok, I will add tests. |
I thinks this is about right. now need tests for this. please rebase, I fixed tests! |
Thanks. I have done it. |
@nikolaydubina tests added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this would do! thanks for adding this!
add io.SeekEnd support