bugfix: pywal should handle if the colours are not present

src/shared/config/pywal.c

@@ -7,24 +7,26 @@
 
 EXP_FUNC bool pywalConfigGetFilename(char *filename) {
     char *a = getenv("XDG_CACHE_HOME");
-    if (a == NULL){
+    if(a == NULL) {
         a = getenv("HOME");
+        // user should not be HOME-less under any circumstances
+        // we will not handle a HOME-less case
+	if(a == NULL)
+            return false;
+
+	sprintf(filename,"%s%s", a, "/.config/wal/colors");
     } else {
-        sprintf(filename,"%s%s",a,"/wal/colors");
-        return true;
-    }
-    if (a == NULL){
-        return false;
-    } else {
-        sprintf(filename,"%s%s",a,"/.cache/wal/colors");
+        sprintf(filename,"%s%s", a, "/wal/colors");
     }
+
     FILE *file = fopen(filename, "r");
-    if ( file != NULL )
-    {
+
+    if(file != NULL) {
         fclose(file);
     } else {
         return false;
     }
+
     return true;
 }
 
@@ -35,27 +37,18 @@ EXP_FUNC void pywalGetColors(unsigned int *fgColorNum, unsigned int *bgColorNum)
     pywalConfigGetFilename(filename);
     FILE *file = fopen(filename, "r");
     int count = 0;
-    if ( file != NULL )
-    {
+    if(file != NULL) {
         char line[256]; /* or other suitable maximum line size */
-        while (fgets(line, sizeof line, file) != NULL) /* read a line */
-        {
-            if (count == lineNumberFg)
-            {
+        while (fgets(line, sizeof line, file) != NULL) {
+            if (count == lineNumberFg) {
                 sscanf(line, "#%06X", fgColorNum);
-            }
-            else if (count == lineNumberBg)
-            {
+            } else if (count == lineNumberBg) {
                 sscanf(line, "#%06X", bgColorNum);
                 break;
-            }
-            else
-            {
-                count++;
-            }
+            } else count++;
         }
+        fclose(file);
     }
-    fclose(file);
     free(filename);
 }