Use idna package for normalize host #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add idna package to dependencies. Remove python 2.7 from supported python versions.
moeb1376
changed the title
JWCook
reviewed
Sep 20, 2023
| @@ -14,8 +14,9 @@ version = "1.4.3" | |||
| "Changelog" = "https://github.com/niksite/url-normalize#url-normalize" | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = "~2.7 || ^3.6" | |||
| python = "^3.6" | |||
| six = "*" | |||
There was a problem hiding this comment.
If python 2.7 support is dropped, six (and its usage in tools.py) could also be removed.
|
I like this idea, since any project dealing with URLs almost certainly already has |
|
We are removind old Python2+3 compat from Debian: I was considering patching this one downstream because I have it on my own PC... but having this change upstream is much better :-) Greetings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add idna package to dependencies.
Remove python 2.7 from supported python versions.