Skip to content

Make damage float up #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nilfm99 merged 2 commits into from
Aug 6, 2025
Merged

Make damage float up #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d1f2be
Fix lockfile
nilfm99 Aug 6, 2025
fec068c
Make damage indicator float up as it disappears
nilfm99 Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/visuals/damage_number_effect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,31 @@ def __init__(
min_size: int = 20,
max_size: int = 80,
) -> None:
super().__init__(2 if is_crit else 1)
super().__init__(self._get_duration(is_crit))
self.ball = ball
self.amount = amount
self.is_crit = is_crit
self.min_size = min_size
self.max_size = max_size

@staticmethod
def _get_duration(is_crit: bool) -> int:
return 2 if is_crit else 1

def _get_font_size(self, damage: int) -> int:
return self.min_size + (self.max_size - self.min_size) * damage // 100

def _get_y_drift(self) -> int:
max_drift = 100
duration = self._get_duration(self.is_crit)
return duration * int(max_drift * (1 - self.timer_seconds / duration))

@override
def draw(self, display: Display) -> None:
color = (255, 0, 0) if not self.is_crit else (255, 180, 0)
font = pygame.font.SysFont('Arial', self._get_font_size(damage=self.amount), bold=True)
alpha = int(255 * (self.timer_seconds / 1.0))
alpha = int(255 * self.timer_seconds / self._get_duration(self.is_crit))
text = f"-{self.amount}"
pos_x = self.ball.body.position.x
pos_y = self.ball.body.position.y - self.ball.radius - 18
pos_y = self.ball.body.position.y - self.ball.radius - 18 - self._get_y_drift()
display.draw_text(text, (pos_x, pos_y), font, color, alpha=alpha)
Loading