fix: fix user email incorrect format#4483
Open
stanislavefremov wants to merge 1 commit intonilsteampassnet:masterfrom
Open
fix: fix user email incorrect format#4483stanislavefremov wants to merge 1 commit intonilsteampassnet:masterfrom
stanislavefremov wants to merge 1 commit intonilsteampassnet:masterfrom
Conversation
sendMailToUser function gets email body in $post_body variable and unconditionally applies htmlspecialchars to it, which escapes html tags. It maybe unneeded as later sendMailToUser passes email body to $emailService->sendMail method which performs XSS check through sanitizeEmailBody method and applies htmlspecialchars if needed.
Author
|
htmlspecialchars in sendMailToUser function seems to be unnecessary. PR suggested as a solution for ##4482 issue |
Contributor
corentin-soriano
left a comment
corentin-soriano
left a comment
There was a problem hiding this comment.
It seems to me that this function is used by mail_me (direct user input). I think wee can add $antiXSS->clean() to clear eventual XSS payload without break the html.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sendMailToUser function gets email body in $post_body variable and unconditionally applies htmlspecialchars to it, which escapes html tags. It maybe unneeded as later sendMailToUser passes email body to $emailService->sendMail method which performs XSS check through sanitizeEmailBody method and applies htmlspecialchars if needed.