Fix for #4693 - Problem with import XML#4744
Open
rafinhamvieira wants to merge 1 commit intonilsteampassnet:masterfrom
Open
Fix for #4693 - Problem with import XML#4744rafinhamvieira wants to merge 1 commit intonilsteampassnet:masterfrom
rafinhamvieira wants to merge 1 commit intonilsteampassnet:masterfrom
Conversation
nilsteampassnet
requested changes
Jun 14, 2025
Owner
nilsteampassnet
left a comment
nilsteampassnet
left a comment
There was a problem hiding this comment.
The commit is not signed
| 'pw_iv' => '', | ||
| 'url' => empty($item['url']) === true ? '' : substr($item['url'], 0, 500), | ||
| 'id_tree' => is_null($item['folder_id']) === true ? $targetFolderId : (int) $item['folder_id'], | ||
| 'id_tree' => isset($post_folders[$item['parentFolderId']]['id']) ? (int)$post_folders[$item['parentFolderId']]['id'] : 0, |
Owner
There was a problem hiding this comment.
Variable $post_folders is not defined in this case
I don't the interest of this change as it will break the execution.
| $params = [ | ||
| 'title' => (string) $currentFolder, | ||
| 'parent_id' => (int) $parentId, | ||
| 'parent_id' => isset($parentId) && $parentId !== null ? $parentId : 0, |
Owner
There was a problem hiding this comment.
Test is correct.
Missing the (int)
| prefixTable('nested_tree'), | ||
| array( | ||
| 'parent_id' => $parentId, | ||
| 'parent_id' => isset($parentId) && $parentId !== null ? $parentId : 0, |
Owner
There was a problem hiding this comment.
Not needed as $parentId is set by function parameter.
As a consequence, it is always defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the code for fix the bug when i try to import XML from keepass