Prevent data mixing between tabs.#4839
Open
corentin-soriano wants to merge 1 commit intonilsteampassnet:masterfrom
Open
Prevent data mixing between tabs.#4839corentin-soriano wants to merge 1 commit intonilsteampassnet:masterfrom
corentin-soriano wants to merge 1 commit intonilsteampassnet:masterfrom
Conversation
corentin-soriano
force-pushed
the
hotfix/multi_tab
branch
from
fe95a72 to
9fb6108
Compare
Owner
There was a problem hiding this comment.
Hi @corentin-soriano
Thank you for this, indeed seems to works smoothly.
QUestion is regarding this file that is included inside store.js component.
I'm a bit concerned about the maintenance of it.
This plugin doesn't evolve regularly but injecting a new file inside it might be a braker in a futur update.
Your position ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
teampassItem,teampassApplication, andteampassSettingstosessionStorageinstead oflocalStorageto avoid mixing data between multiple open tabs.store.everything.session.min.js is a modified copy of store.everything.min.js to use
sessionStorageand exposestoreSessionobject.store=> Local Storage (shared between all tabs).storeSession=> Session Storage (not shared between tabs).