Open
Conversation
6 tasks
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 5 in repo nimanch/iotedge |
kodiakhq bot
pushed a commit
to Azure/iotedge
that referenced
this pull request
Oct 22, 2021
This PR Adds a Gate which triggers E2E Test Run for a Pull Request. Currently only Ubuntu 18.04 AMD64 E2E Test has been added to save time. As we optimize more, more platforms would be added 1. Added e2e-checkin.yaml. 2. Modularize images.yaml and packages.yaml to allow using build components for e2e checkin gate. 3. Add Conditions to selectively trigger Building Images and Packages. Edgelet Packages will only be built if there are changes in edgelet directory. Images will only be built if there are changes outside of test or doc directory TODO **AFTER** Merging PR 1. Add new pipeline and configure it to use e2e-checkin.yaml 2. Work with Repo Admin to add Status Check to run E2E Pipeline 3. Notify Team about Comment Triggers Testing 1. Testing was done via setting up a private pipeline : https://dev.azure.com/msazure/One/_build/results?buildId=48064485&view=results 2. As a test , created a PR to in my private fork : nimanch#4 which trigger an E2E Test run : https://dev.azure.com/msazure/One/_build/results?buildId=48067190&view=results 3. Created a dummy Pull Request to my private fork with an external alias. Verified the E2E Gate does not trigger automatically. nimanch#5 4. Created a dummy PR to my private fork with an external alias. Verified that after Commenting "/azp run" with my MSFT Github account, A Pipeline run was triggered : nimanch#6 5. Verified Existing Build Images and Build Packages Pipelines work as expected 6. Verified that existing CI E2E Test Run uses the correct artifacts ( Resource Artifacts) -> https://msazure.visualstudio.com/One/_build/results?buildId=48091890&view=logs&j=f1061aa8-bee6-5103-5b5c-2b2c91b98c58 7. Verified that an External Alias cannot trigger E2E Test Run by Commenting /azp run on the PR . nimanch#5 Testing done ## Azure IoT Edge PR checklist: This checklist is used to make sure that common guidelines for a pull request are followed. ### General Guidelines and Best Practices - [x] I have read the [contribution guidelines](https://github.com/azure/iotedge#contributing). - [x] Title of the pull request is clear and informative. - [x] Description of the pull request includes a concise summary of the enhancement or bug fix. ### Testing Guidelines - [x] Pull request includes test coverage for the included changes. - Description of the pull request includes - [x] concise summary of tests added/modified - [x] local testing done. ### Draft PRs - Open the PR in `Draft` mode if it is: - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. _Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned [here](https://chris.beams.io/posts/git-commit/#:~:text=The%20seven%20rules%20of%20a%20great%20Git%20commit,what%20and%20why%20vs.%20how%20For%20example%3A%20) for the PR title and description_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please replace this line with your PR description and read PR checklist below
Azure IoT Edge PR checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines and Best Practices
Testing Guidelines
Draft PRs
Draftmode if it is:Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned here for the PR title and description