Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change aside overflow to 'auto' instead of 'overflow-y-scroll' #86

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ yarn-error.log*

# local env files
.env*.local
.env

# vercel
.vercel
Expand Down
18 changes: 14 additions & 4 deletions app/(links)/layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,24 @@ import { getLinkCategories } from "@/modules/content/category";
import { getLinks } from "@/modules/content/link";
import { ReactNode } from "react";

export default async function LinksLayout({ children }: { children: ReactNode }) {
const [linkCategories, links] = await Promise.all([getLinkCategories(), getLinks()]);
export default async function LinksLayout({
children,
}: {
children: ReactNode;
}) {
const [linkCategories, links] = await Promise.all([
getLinkCategories(),
getLinks(),
]);

return (
<main className="md:flex h-full">
<div className="hidden md:block">
<aside className="flex-none sticky top-0 h-screen w-[16rem] lg:w-[22rem] border-r p-4 overflow-y-scroll">
<DesktopLinksSidebarContent categories={linkCategories} links={links} />
<aside className="flex-none sticky top-0 h-screen w-[16rem] lg:w-[22rem] border-r p-4 overflow-auto">
<DesktopLinksSidebarContent
categories={linkCategories}
links={links}
/>
</aside>
</div>

Expand Down