Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixvalueasstringerror #83

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Conversation

vladbelozertsev
Copy link
Contributor

Hi, i found a better solution for types, please check it.
Changes:

  1. We don’t need to add numbered styles by hands. String type (‘@ms ’, ‘@vs’, etc) automatically add to all numbered styles. It means StringifiedStyles is unnecessary for now.
  2. I add TS regex types for sizes, based on documentation. For example in current version we can write without error something like - {fontSize: ‘any-symbols’}. In this PR regex types solve the problem. I check, regex types work since last RN version (0.72.4), because of style types was updated - removed ‘string’ type from styles that consume a number value. This is actually why RNSM types have broken
    Thanks

@nirsky
Copy link
Owner

nirsky commented Sep 28, 2023

Hey @vladbelozertsev! Looks good but there some conflicts with your previous commit. Can you please resolve them?

@vladbelozertsev
Copy link
Contributor Author

@nirsky done.

@vladbelozertsev
Copy link
Contributor Author

Is it ok? Or mb better to create a new fork?

@endyinthesun
Copy link

@vladbelozertsev hi! Could you create a new PR and add "rowGap", "columnGap" and "gap"?

@nirsky nirsky merged commit f39ea6e into nirsky:master Oct 3, 2023
1 check passed
@vladbelozertsev
Copy link
Contributor Author

@endyinthesun hi, is it your specific values? They are not includes to documentation

@vladbelozertsev
Copy link
Contributor Author

vladbelozertsev commented Oct 3, 2023

@endyinthesun oh sry, its basic css styles, they are included to current PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants