refactor: fix variable shadowing and improve type assertion safety ac…

[0x5487]

…ross multiple packages

[codecov]

Codecov Report

❌ Patch coverage is 67.34955% with 255 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
pkg/variable/pkg.go	57.62%	17 Missing and 8 partials ⚠️
pkg/gateway/pkg.go	33.33%	22 Missing and 2 partials ⚠️
internal/pkg/runtime/zero.go	18.51%	22 Missing ⚠️
internal/pkg/runtime/controlplane.go	30.00%	11 Missing and 10 partials ⚠️
pkg/config/pkg.go	56.81%	16 Missing and 3 partials ⚠️
pkg/gateway/upstream.go	66.00%	17 Missing ⚠️
pkg/proxy/grpc/proxy.go	63.15%	10 Missing and 4 partials ⚠️
pkg/proxy/http/proxy.go	55.17%	13 Missing ⚠️
pkg/gateway/service.go	74.35%	9 Missing and 1 partial ⚠️
internal/pkg/runtime/worker_fd.go	42.85%	5 Missing and 3 partials ⚠️
... and 24 more

Files with missing lines	Coverage Δ
internal/pkg/consistent/consistent.go	93.81% <100.00%> (ø)
internal/pkg/hzadaptor/request.go	95.55% <100.00%> (+0.20%)	⬆️
internal/pkg/runtime/keepalive.go	100.00% <100.00%> (ø)
internal/pkg/runtime/procname_linux.go	75.00% <100.00%> (ø)
pkg/balancer/chash/hashing.go	89.36% <100.00%> (ø)
pkg/balancer/pkg.go	0.00% <ø> (ø)
pkg/balancer/random/random.go	100.00% <100.00%> (ø)
pkg/balancer/roundrobin/round_robin.go	100.00% <100.00%> (ø)
pkg/balancer/weighted/weighted.go	88.09% <100.00%> (ø)
pkg/config/error.go	100.00% <ø> (ø)
... and 76 more

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[gemini-code-assist]

Code Review

This pull request focuses on improving code robustness and maintainability by addressing potential runtime panics and variable shadowing. Key changes include implementing safe type assertions using the 'ok' pattern across multiple packages, renaming error variables to avoid shadowing, and pre-declaring variables to clarify scope. Additionally, the .golangci.yml configuration was updated to include new linters such as lll, noinlineerr, and nlreturn. I have no feedback to provide.

[0x5487]

/gemini review

[gemini-code-assist]

Code Review

This pull request aims to resolve linting warnings, specifically variable shadowing, while improving code documentation and safety. It introduces enums for operational modes and adds comments to exported entities. However, the reviewer noted several critical compilation errors caused by calling a non-existent Go method on sync.WaitGroup. Feedback also highlights a regression in panic recovery during server shutdown and advises against disabling essential linters in .golangci.yml, as it contradicts the PR's objective of improving code quality.