Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(qsign): add qsign client support #45

Merged
merged 3 commits into from
Sep 18, 2023
Merged

feat(qsign): add qsign client support #45

merged 3 commits into from
Sep 18, 2023

Conversation

LovesAsuna
Copy link
Contributor

No description provided.

@niuhuan
Copy link
Owner

niuhuan commented Sep 16, 2023

Dev分支有合并过类似代码，可以看一下最近的PR。和dev最后的commit

@LovesAsuna
Copy link
Contributor Author

现在确实必须要用

@LovesAsuna
Copy link
Contributor Author

LovesAsuna commented Sep 16, 2023 •
edited
Loading

看了一下dev分支，这个写死url和key不好吧，还有为啥不直接用master要用rev

@niuhuan
Copy link
Owner

niuhuan commented Sep 16, 2023

既然一定要使用，那么可以直接合并到Master。如果可以的话，补充一下qsign的文档就更好了。

@LovesAsuna
Copy link
Contributor Author

虽然很早就知道要用qsign了，但好久没写代码了这玩意一直没看，今晚才研究了一下qsign怎么搞😭，文档明天再补好了

@LovesAsuna
Copy link
Contributor Author

文档加上去了。另外好像登录拿ticket有点问题，现在会一直卡住

@niuhuan niuhuan merged commit 7ad3989 into niuhuan:master Sep 18, 2023
8 checks passed
@niuhuan
Copy link
Owner

niuhuan commented Sep 19, 2023

会一直卡住 的问题可能是我改了获取ticket的方式。改成了trait，如果有BUG可以PR一下。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LovesAsuna @niuhuan