-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: clarify extraEmacsPackages
usage
#452
Conversation
Another issue is that this only works when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am strongly against using propagatedUserEnvPkgs
here. The reasons are as follows:
propagatedUserEnvPkgs
has issues. See links in [documentation] There is no documentation forpropagatedUserEnvPkgs
NixOS/nixpkgs#347093.- Here, we use
emacsWithPackages
which will addbin
dirs of packages inextraEmacsPackages
toexec-path
. To find executables, Emacs lisp packages should respectexec-path
by using functions likeexecutable-find
. If one Emacs lisp package do not respectexec-path
, that package itself should be fixed. - I use
propagatedUserEnvPkgs
in themu4e
package only to support unrecommended use cases whereemacsWithPackages
is not used. For example, users install Emacs lisp packages by adding them toenvironment.systemPackages
.
Ight, I'm limiting this edit only to README, where i clarify that one can just use |
da4b975
to
78fd280
Compare
extraEmacsPackages
to extraPackages
, update README
78fd280
to
96c5175
Compare
extraEmacsPackages
to extraPackages
, update READMEextraEmacsPackages
usage
96c5175
to
237a885
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Inspired by
mu4e
's recipeNow here's a lil issue i'd love to resolve:
nix build|run
such a closure,extraPackages
won't be availablenix profile install
or adding it toenvironment.systemPackages
/home.packages
),extraPackages
can be propagated.*Is this behaviour fine as is or should I make
extraPackages
always available?*Just tried with
nixos-rebuild test
, somehow this doesn't work 🤔