Allow using a list of paths in emacsWithPackagesFromUsePackage #465
Conversation
|
This can be done downstream, of course, but I think it's neater to have actual support for it. |
TLATER
force-pushed
the
tlater/list-packages
branch
2 times, most recently
from
5e2b7c0 to
9971ad4
Compare
elisp.nix
Outdated
| @@ -40,6 +40,8 @@ let | |||
| else if type == "string" then config | |||
| # - A config path { config = ./config.el; } | |||
| else if type == "path" then builtins.readFile config | |||
| # - A list of paths { config = [ ./config.el ./custom.el ] } | |||
| else if type == "list" then lib.concatMapStringsSep "\n" (fname: builtins.readFile fname) config | |||
There was a problem hiding this comment.
Eta reduction
| else if type == "list" then lib.concatMapStringsSep "\n" (fname: builtins.readFile fname) config | |
| else if type == "list" then lib.concatMapStringsSep "\n" builtins.readFile config |
There was a problem hiding this comment.
Presumably because you do not apply my suggestion as is and instead an extra map is added which breaks the code.
There was a problem hiding this comment.
I did, both lib.concatMapStringsSep and the indirect lib.concatStringsSep (map ... result in unresolved thunks. This commit only uses the latter because in a narrow scenario that did resolve them, whereas lib.concatMapStringsSep did not. I'd figured that it's maybe because lib.concatMapStringsSep demands specifically strings from its input list, but that's clearly not it (and would not make any sense).
I'm stumped, but I'll have to try again another time. It works fine downstream fwiw, maybe this is a weird edge case of ${self} in flakes.
elisp.nix
Outdated
| # - A list of paths { config = [ ./config.el ./custom.el ] } | ||
| else if type == "list" then lib.concatMapStringsSep "\n" (fname: builtins.readFile fname) config |
There was a problem hiding this comment.
I am slightly against this because the check type == "list" is weaker than a list of paths.
EDIT: This PR seems to be under active working and not stable yet. I unsubscribed this PR to stop receiving email notifications about "pushed 1 commit". Please @ me if you want me to receive your message or re-request my review using a github button when this PR is ready.
There was a problem hiding this comment.
Yep, agreed, I suppose a check of what the list elements actually are is possible.
This permits creating use-package/leaf package lists for full configuration directories, instead of just single big config files.
TLATER
force-pushed
the
tlater/list-packages
branch
from
9971ad4 to
5de1626
Compare
|
This... Doesn't seem to work in practice, somehow, I'd only tested it without going through the full entrypoint. Somehow going here makes nix not resolve the Unsure how this is even possible, but I'll have to dig into this a bit deeper than I can right this evening. |
This permits creating use-package/leaf package lists for full configuration directories, instead of just single big config files, at least unless I misunderstand something quite a bit.