-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hm: option for default linking method #182
Conversation
Can confirm there are no diffs in my home path when running this branch versus the main branch |
I've been using this PR for about a week now and everything is working great on my end. Thank you both for your work on this PR and project :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your work on this! Looks great! Just some minor comments.
Hi @talyz @Misterio77 Don't want to necrobump, but is there something except minor comments blocking this PR? This feature would be handy. |
Hey, sorry for the delay! Got quite busy last semester. Will see if I can get this going. |
65a12c0
to
68ac02a
Compare
68ac02a
to
8825ba2
Compare
Nevermind, was an error in my own config. This PR should be good. |
Thanks! |
@Misterio77 thanks for this PR, I REALLY appreciate it. I've just been patching impermanence for a long while, instead of doing it properly. Thanks for the effort! :) |
Hi all!
Here's a (slightly late) follow up to #99.
This adds an option that allows users to change the default linking method.
Bindfs has been bothering me with the performance hits, and writing
method = symlink
for every entry is cumbersome. The default still is bindfs, so no breaking changes.To make this implementation cleaner, I also refactored the directory type to use coercedTo (in its own commit, to be easier to review).