Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hm: option for default linking method #182

Merged
merged 5 commits into from
Jan 25, 2025

Conversation

Misterio77
Copy link
Contributor

Hi all!

Here's a (slightly late) follow up to #99.

This adds an option that allows users to change the default linking method.

Bindfs has been bothering me with the performance hits, and writing method = symlink for every entry is cumbersome. The default still is bindfs, so no breaking changes.

To make this implementation cleaner, I also refactored the directory type to use coercedTo (in its own commit, to be easier to review).

@Misterio77
Copy link
Contributor Author

Can confirm there are no diffs in my home path when running this branch versus the main branch

@maxbfuer
Copy link

maxbfuer commented Jun 4, 2024

I've been using this PR for about a week now and everything is working great on my end. Thank you both for your work on this PR and project :)

Copy link
Collaborator

@talyz talyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your work on this! Looks great! Just some minor comments.

@fbuchlak
Copy link

Hi @talyz @Misterio77 Don't want to necrobump, but is there something except minor comments blocking this PR? This feature would be handy.

@Misterio77
Copy link
Contributor Author

Hey, sorry for the delay! Got quite busy last semester. Will see if I can get this going.

@Misterio77
Copy link
Contributor Author

Should be good to go!

CC @talyz @fbuchlak

@Misterio77
Copy link
Contributor Author

Misterio77 commented Jan 25, 2025

Oops sorry, hold on a bit. Got some eval errors after rebasing.

Nevermind, was an error in my own config. This PR should be good.

@talyz talyz merged commit 4b3e914 into nix-community:master Jan 25, 2025
4 checks passed
@talyz
Copy link
Collaborator

talyz commented Jan 25, 2025

Thanks!

@eyJhb
Copy link
Contributor

eyJhb commented Feb 7, 2025

@Misterio77 thanks for this PR, I REALLY appreciate it. I've just been patching impermanence for a long while, instead of doing it properly. Thanks for the effort! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants