Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/shared/community-builder: add github token to nix.conf #1542

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Oct 29, 2024

No description provided.

@zowoq zowoq force-pushed the community-tokens branch 4 times, most recently from 2ca7ec1 to 7c40d74 Compare October 29, 2024 01:46
@zowoq zowoq marked this pull request as ready for review October 29, 2024 01:59
@zowoq zowoq requested review from zimbatm and Mic92 October 29, 2024 01:59
darwin02 = knownHosts.darwin02.publicKey;
web02 = knownHosts.web02.publicKey;

secrets = {
# fine-grained, no permissions github token from `nix-infra-bot`, expires 2025-10-29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has the bot still any permission in our infrastructure?
Otherwise I would suggest to make this a new bot, just in case github messes up their API at some point in the future.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can also make one if this is the limiting factor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has the bot still any permission in our infrastructure?

No. Currently it is used in two places, a collaborator in the nixvim repo for mergify to use for rebasing PRs and another token without permissions is used for the nixpkgs-update-github-releases service.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also still have the nix-community-buildbot user account that isn't used for anything at all, I'll use that instead.

@zowoq zowoq added this pull request to the merge queue Oct 31, 2024
@zowoq zowoq removed this pull request from the merge queue due to a manual request Oct 31, 2024
@zowoq zowoq added this pull request to the merge queue Oct 31, 2024
Merged via the queue into master with commit 0682c61 Oct 31, 2024
3 checks passed
@zowoq zowoq deleted the community-tokens branch October 31, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants