platform refactor #446

faukah · 2025-10-15T23:27:58Z

Move core logic to platform.rs.
Depends on #436 and #445.

Sanity Checking

Add a 👍 reaction to pull requests you find important.

coderabbitai · 2025-10-15T23:28:07Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

There is no point in making the attribute of an Installable be a Vec. Attributes can are used in one of: - Flake: FLAKEREF#ATTRIBUTE: Here, we cannot pass multiple attributes anyways. - File, Expression: The Nix expression (in that file), or any selected attribute, must evaluate to a derivation. It is fine to only accept a single attribute here, since no one is going to add several attributes corresponding to {nixos,home,darwin}Configurations, here.

github-actions · 2025-11-17T23:16:21Z

Performance Comparison `→`

Total Elapsed Time: 343.05ms → 261.40ms (-23.8%) 🚀

Profiling Mode: timing - Execution duration of functions.

+------------------------------------+---------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| Function                           | Calls               | Avg                              | P95                              | Total                            | % Total                      |
+------------------------------------+---------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| main                               | 1 → 1 (+0.0%)       | 342.37ms → 260.73ms (-23.8%) 🚀  | 342.62ms → 260.83ms (-23.9%) 🚀  | 342.37ms → 260.73ms (-23.8%) 🚀  | 100.00% → 100.00% (+0.0%)    |
+------------------------------------+---------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| nh::search::run                    | 1 → 1 (+0.0%)       | 291.10ms → 204.16ms (-29.9%) 🚀  | 291.24ms → 204.21ms (-29.9%) 🚀  | 291.10ms → 204.16ms (-29.9%) 🚀  | 85.02% → 78.30% (-7.9%)      |
+------------------------------------+---------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| http_request                       | 1 → 1 (+0.0%)       | 226.98ms → 199.18ms (-12.2%)     | 227.02ms → 199.23ms (-12.2%)     | 226.98ms → 199.18ms (-12.2%)     | 66.29% → 76.39% (+15.2%)     |
+------------------------------------+---------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| nh::checks::check_nix_version      | 1 → 1 (+0.0%)       | 50.68ms → 55.94ms (+10.4%)       | 50.69ms → 55.97ms (+10.4%)       | 50.68ms → 55.94ms (+10.4%)       | 14.80% → 21.45% (+44.9%) ⚠️  |
+------------------------------------+---------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| nh::checks::verify_nix_environment | 1 → 1 (+0.0%)       | 50.68ms → 55.94ms (+10.4%)       | 50.69ms → 55.97ms (+10.4%)       | 50.68ms → 55.94ms (+10.4%)       | 14.80% → 21.45% (+44.9%) ⚠️  |
+------------------------------------+---------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| nh::util::get_nix_version          | 1 → 1 (+0.0%)       | 23.97ms → 26.55ms (+10.8%)       | 23.97ms → 26.56ms (+10.8%)       | 23.97ms → 26.55ms (+10.8%)       | 7.00% → 10.18% (+45.4%) ⚠️   |
+------------------------------------+---------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| ️🗑️ json_parse                      | 1 → 0 (-100.0%) 🚀  | 32.23ms → 0.00ns (-100.0%) 🚀    | 32.23ms → 0.00ns (-100.0%) 🚀    | 32.23ms → 0.00ns (-100.0%) 🚀    | 9.41% → 0.00% (-100.0%) 🚀   |
+------------------------------------+---------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+

Generated with hotpath

📊 View Raw JSON Metrics

PR Metrics

{
  "hotpath_profiling_mode": "timing",
  "total_elapsed": 261399948,
  "description": "Execution duration of functions.",
  "caller_name": "main",
  "output": {
    "http_request": {
      "calls": 1,
      "avg": 199182376,
      "p95": 199229439,
      "total": 199182376,
      "percent_total": 7639
    },
    "main": {
      "calls": 1,
      "avg": 260729287,
      "p95": 260833279,
      "total": 260729287,
      "percent_total": 10000
    },
    "nh::checks::check_nix_version": {
      "calls": 1,
      "avg": 55936954,
      "p95": 55967743,
      "total": 55936954,
      "percent_total": 2145
    },
    "nh::checks::verify_nix_environment": {
      "calls": 1,
      "avg": 55942454,
      "p95": 55967743,
      "total": 55942454,
      "percent_total": 2145
    },
    "nh::util::get_nix_version": {
      "calls": 1,
      "avg": 26554078,
      "p95": 26558463,
      "total": 26554078,
      "percent_total": 1018
    },
    "nh::search::run": {
      "calls": 1,
      "avg": 204158395,
      "p95": 204210175,
      "total": 204158395,
      "percent_total": 7830
    }
  }
}

Main Branch Metrics

{
  "hotpath_profiling_mode": "timing",
  "total_elapsed": 343053759,
  "description": "Execution duration of functions.",
  "caller_name": "main",
  "output": {
    "json_parse": {
      "calls": 1,
      "avg": 32225480,
      "p95": 32227327,
      "total": 32225480,
      "percent_total": 941
    },
    "nh::search::run": {
      "calls": 1,
      "avg": 291102049,
      "p95": 291241983,
      "total": 291102049,
      "percent_total": 8502
    },
    "nh::util::get_nix_version": {
      "calls": 1,
      "avg": 23967247,
      "p95": 23969791,
      "total": 23967247,
      "percent_total": 700
    },
    "nh::checks::verify_nix_environment": {
      "calls": 1,
      "avg": 50683244,
      "p95": 50692095,
      "total": 50683244,
      "percent_total": 1480
    },
    "main": {
      "calls": 1,
      "avg": 342373131,
      "p95": 342622207,
      "total": 342373131,
      "percent_total": 10000
    },
    "http_request": {
      "calls": 1,
      "avg": 226979558,
      "p95": 227016703,
      "total": 226979558,
      "percent_total": 6629
    },
    "nh::checks::check_nix_version": {
      "calls": 1,
      "avg": 50675489,
      "p95": 50692095,
      "total": 50675489,
      "percent_total": 1480
    }
  }
}

github-actions · 2025-11-17T23:16:22Z

Performance Comparison `→`

Total Elapsed Time: 333.47ms → 348.01ms (+4.4%)

Profiling Mode: alloc_bytes_total - Cumulative bytes allocated during each function call (including nested calls).

+------------------------------------+------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| Function                           | Calls            | Avg                              | P95                              | Total                            | % Total                      |
+------------------------------------+------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| main                               | 1 → 1 (+0.0%)    | 2.3 MB → 2.3 MB (+0.0%)          | 2.3 MB → 2.3 MB (+0.0%)          | 2.3 MB → 2.3 MB (+0.0%)          | 100.00% → 100.00% (+0.0%)    |
+------------------------------------+------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| nh::checks::check_nix_version      | 1 → 1 (+0.0%)    | 1017.8 KB → 1017.8 KB (+0.0%)    | 1018.0 KB → 1018.0 KB (+0.0%)    | 1017.8 KB → 1017.8 KB (+0.0%)    | 44.00% → 44.00% (+0.0%)      |
+------------------------------------+------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| nh::checks::verify_nix_environment | 1 → 1 (+0.0%)    | 1017.8 KB → 1017.8 KB (+0.0%)    | 1018.0 KB → 1018.0 KB (+0.0%)    | 1017.8 KB → 1017.8 KB (+0.0%)    | 44.00% → 44.00% (+0.0%)      |
+------------------------------------+------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| nh::search::run                    | 1 → 1 (+0.0%)    | 372.4 KB → 372.4 KB (+0.0%)      | 372.5 KB → 372.5 KB (+0.0%)      | 372.4 KB → 372.4 KB (+0.0%)      | 16.09% → 16.09% (+0.0%)      |
+------------------------------------+------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| json_parse                         | 1 → 1 (+0.0%)    | 152.3 KB → 152.3 KB (+0.0%)      | 152.4 KB → 152.4 KB (+0.0%)      | 152.3 KB → 152.3 KB (+0.0%)      | 6.58% → 6.58% (+0.0%)        |
+------------------------------------+------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| nh::util::get_nix_version          | 1 → 1 (+0.0%)    | 824 B → 824 B (+0.0%)            | 824 B → 824 B (+0.0%)            | 824 B → 824 B (+0.0%)            | 0.03% → 0.03% (+0.0%)        |
+------------------------------------+------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+
| http_request                       | 1 → 1 (+0.0%)    | 325 B → 325 B (+0.0%)            | 325 B → 325 B (+0.0%)            | 325 B → 325 B (+0.0%)            | 0.01% → 0.01% (+0.0%)        |
+------------------------------------+------------------+----------------------------------+----------------------------------+----------------------------------+------------------------------+

Generated with hotpath

📊 View Raw JSON Metrics

PR Metrics

{
  "hotpath_profiling_mode": "alloc-bytes-total",
  "total_elapsed": 348010696,
  "description": "Cumulative bytes allocated during each function call (including nested calls).",
  "caller_name": "main",
  "output": {
    "http_request": {
      "calls": 1,
      "avg": 325,
      "p95": 325,
      "total": 325,
      "percent_total": 1
    },
    "nh::util::get_nix_version": {
      "calls": 1,
      "avg": 824,
      "p95": 824,
      "total": 824,
      "percent_total": 3
    },
    "nh::checks::check_nix_version": {
      "calls": 1,
      "avg": 1042176,
      "p95": 1042431,
      "total": 1042176,
      "percent_total": 4400
    },
    "nh::checks::verify_nix_environment": {
      "calls": 1,
      "avg": 1042176,
      "p95": 1042431,
      "total": 1042176,
      "percent_total": 4400
    },
    "json_parse": {
      "calls": 1,
      "avg": 155968,
      "p95": 156031,
      "total": 155968,
      "percent_total": 658
    },
    "main": {
      "calls": 1,
      "avg": 2368512,
      "p95": 2369535,
      "total": 2368512,
      "percent_total": 10000
    },
    "nh::search::run": {
      "calls": 1,
      "avg": 381312,
      "p95": 381439,
      "total": 381312,
      "percent_total": 1609
    }
  }
}

Main Branch Metrics

{
  "hotpath_profiling_mode": "alloc-bytes-total",
  "total_elapsed": 333466042,
  "description": "Cumulative bytes allocated during each function call (including nested calls).",
  "caller_name": "main",
  "output": {
    "nh::checks::verify_nix_environment": {
      "calls": 1,
      "avg": 1042176,
      "p95": 1042431,
      "total": 1042176,
      "percent_total": 4400
    },
    "json_parse": {
      "calls": 1,
      "avg": 155968,
      "p95": 156031,
      "total": 155968,
      "percent_total": 658
    },
    "main": {
      "calls": 1,
      "avg": 2368512,
      "p95": 2369535,
      "total": 2368512,
      "percent_total": 10000
    },
    "nh::checks::check_nix_version": {
      "calls": 1,
      "avg": 1042176,
      "p95": 1042431,
      "total": 1042176,
      "percent_total": 4400
    },
    "nh::search::run": {
      "calls": 1,
      "avg": 381312,
      "p95": 381439,
      "total": 381312,
      "percent_total": 1609
    },
    "nh::util::get_nix_version": {
      "calls": 1,
      "avg": 824,
      "p95": 824,
      "total": 824,
      "percent_total": 3
    },
    "http_request": {
      "calls": 1,
      "avg": 325,
      "p95": 325,
      "total": 325,
      "percent_total": 1
    }
  }
}

faukah added 4 commits October 20, 2025 14:07

installable: clean up augment_args

190d690

util: platform: format

bd71780

platform: WIP

6509713

faukah force-pushed the faukah/platform-refactor branch from a1479d6 to 6509713 Compare October 20, 2025 12:08

NotAShelf added 2 commits November 15, 2025 11:54

Merge branch 'master' into faukah/platform-refactor

da68e1f

Merge branch 'master' into faukah/platform-refactor

afe4cdd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

platform refactor #446

platform refactor #446

faukah commented Oct 15, 2025

Uh oh!

coderabbitai bot commented Oct 15, 2025

Review skipped

Uh oh!

github-actions bot commented Nov 17, 2025

PR Metrics

Main Branch Metrics

Uh oh!

github-actions bot commented Nov 17, 2025

PR Metrics

Main Branch Metrics

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

platform refactor #446

Are you sure you want to change the base?

platform refactor #446

Conversation

faukah commented Oct 15, 2025

Sanity Checking

Uh oh!

coderabbitai bot commented Oct 15, 2025

Review skipped

Uh oh!

github-actions bot commented Nov 17, 2025

Performance Comparison →

PR Metrics

Main Branch Metrics

Uh oh!

github-actions bot commented Nov 17, 2025

Performance Comparison →

PR Metrics

Main Branch Metrics

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Performance Comparison `→`

Performance Comparison `→`