-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GNU/Hurd support #2131
Add GNU/Hurd support #2131
Conversation
a65bb09
to
d939870
Compare
This is unrelated. This actually looks to me like a false positive from clippy: the code does mean not to loop and just panic if we make even just one iteration. |
Hi, thanks for your contribution to nix! Unfortunately, our Cirrus CI is running out of its credits, so I manually stopped the CI for this PR. After our migration to GitHub action, I will take a look at this PR and re-run the CI job |
I have rebased on top of the github action commit |
And I have now added i686-unknown-hurd-gnu as tier3 in CI. Obviously, in the meanwhile some errors have popped up, I'll have a look. |
2a718c8
to
4775b9d
Compare
Some fixes need to be done in libc (and wait for a libc release...) |
Ok, then I will label this |
848da27
to
11dfa98
Compare
You'll have to rebase to fix CI. |
ok, done so! |
@SteveLauC do you need to change the minimum libc version? CI's minver check won't catch an error there, if the error only affects Hurd. |
hi @sthibaul, is this PR blocked by these changes? These changes haven't been released yet, so I guess we still need to wait for a new libc release |
Hi @sthibaul, now we are ok to use the libc dependency from git so that we don't have to wait for a libc release. And, rebasing your branch should make the CI pass since the commit used already has these 2 PRs covered I am sorry about those merge conflicts, we have switched to cfg alias to make our code clean, and this PR is mostly about cfg, so... |
491d766
to
dfddc62
Compare
Ok, at last it does pass... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
AIUI it is waiting for @asomers ' ack? |
Yeah, that would be best, let's wait for asomers's review:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.