fcntl: Adding F_TRANSFEREXTENTS fcntl constant for macOs. #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveLauC
approved these changes
Sep 15, 2024
| /// The other file is specified via a file descriptor as the lone extra argument. | ||
| /// Both descriptors must reference regular files in the same volume. | ||
| #[cfg(apple_targets)] | ||
| F_TRANSFEREXTENTS(RawFd), |
There was a problem hiding this comment.
Hmm, just realized that I missed this type when added I/O safety to this module. 😵💫
|
Yes I planned to keep it as draft as long as it takes :) |
That's totally fine:) |
SteveLauC
reviewed
Nov 18, 2024
src/fcntl.rs
Outdated
| @@ -952,6 +958,12 @@ pub fn fcntl<Fd: std::os::fd::AsFd>(fd: Fd, arg: FcntlArg) -> Result<c_int> { | |||
| F_PREALLOCATE(st) => { | |||
| libc::fcntl(fd, libc::F_PREALLOCATE, st) | |||
| }, | |||
| #[cfg(apple_targets)] | |||
| F_TRANSFEREXTENTS(rawfd) => { | |||
| // FIXME: ongoing (PR)[https://github.com/rust-lang/libc/pull/3925/files] | |||
There was a problem hiding this comment.
This PR has been merged and backported to the libc-0.2 branch:)
devnexen
force-pushed
the
fcntl_transferextents
branch
from
96ca676 to
307ccd3
Compare
SteveLauC
reviewed
Nov 18, 2024
src/fcntl.rs
Outdated
Comment on lines
963
to
965
| // FIXME: ongoing (PR)[https://github.com/rust-lang/libc/pull/3925/files] | ||
| const F_TRANSFEREXTENTS: c_int = 110; | ||
| libc::fcntl(fd, F_TRANSFEREXTENTS, rawfd) |
There was a problem hiding this comment.
Let's use the constant from the libc crate:
Suggested change
| // FIXME: ongoing (PR)[https://github.com/rust-lang/libc/pull/3925/files] | |
| const F_TRANSFEREXTENTS: c_int = 110; | |
| libc::fcntl(fd, F_TRANSFEREXTENTS, rawfd) | |
| libc::fcntl(fd, libc::F_TRANSFEREXTENTS, rawfd) |
There was a problem hiding this comment.
Yes I forgot to change in fact..
devnexen
force-pushed
the
fcntl_transferextents
branch
from
eafc43e to
a6e589a
Compare
SteveLauC
reviewed
Nov 18, 2024
src/fcntl.rs
Outdated
| @@ -952,6 +958,11 @@ pub fn fcntl<Fd: std::os::fd::AsFd>(fd: Fd, arg: FcntlArg) -> Result<c_int> { | |||
| F_PREALLOCATE(st) => { | |||
| libc::fcntl(fd, libc::F_PREALLOCATE, st) | |||
| }, | |||
| #[cfg(apple_targets)] | |||
| F_TRANSFEREXTENTS(rawfd) => { | |||
| // FIXME: ongoing (PR)[https://github.com/rust-lang/libc/pull/3925/files] | |||
There was a problem hiding this comment.
Still has a comment to remove:)
devnexen
force-pushed
the
fcntl_transferextents
branch
from
a6e589a to
00b7adc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.