Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use Cow::<str>::to_string #2570

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Don't use Cow::<str>::to_string #2570

merged 1 commit into from
Dec 26, 2024

Conversation

CryZe
Copy link
Contributor

@CryZe CryZe commented Dec 25, 2024

What does this PR do

The existing code accidentally dropped the possibly already existing owned value.

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@CryZe
Don't use Cow::<str>::to_string
35a11a7 
The existing code accidentally dropped the possibly already existing
owned value.
@CryZe
Copy link
Contributor Author

CryZe commented Dec 25, 2024

The test failure seems unrelated / spurious.

SteveLauC
SteveLauC approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for optimizing it!

@SteveLauC SteveLauC enabled auto-merge December 26, 2024 05:47
@SteveLauC SteveLauC added this pull request to the merge queue Dec 26, 2024
Merged via the queue into nix-rust:master with commit e789a7c Dec 26, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveLauC SteveLauC SteveLauC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CryZe @SteveLauC