Skip to content

Conversation

Gelbpunkt
Copy link

What does this PR do

This PR fixes compilation against libc 0.2.176 on s390x-unknown-linux-musl. libc 0.2.176 fixed the definitions of statfs to align them with musl, see rust-lang/libc#4549 for the PR that fixed it.

I'm not sure why libc is currently pinned to 0.2.175, but I tested this locally against 0.2.176 on s390x-unknown-linux-gnu and s390x-unknown-linux-musl and the statfs code compiles fine for both now.

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

Signed-off-by: Jens Reidel <adrian@travitia.xyz>
@neuschaefer
Copy link

What does this PR do

This PR fixes compilation against libc 0.2.176 on s390x-unknown-linux-musl. libc 0.2.176 fixed the definitions of statfs to align them with musl, see rust-lang/libc#4549 for the PR that fixed it.

I'm not sure why libc is currently pinned to 0.2.175, but I tested this locally against 0.2.176 on s390x-unknown-linux-gnu and s390x-unknown-linux-musl and the statfs code compiles fine for both now.

The PR description (at least the first paragraph) might be worth having in the git history (i.e. in the commit message)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants