Remove support for reading YAML files #22
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already introduced deprecation warnings back in 49b889b, telling people that we're going to remove YAML in version 3.0. With this, the removal is essentially done and we now no longer depend on yaml-cpp, nor do we need pkg-config or anything like that, because we essentially have zero (external) library dependencies except libc and libdl. This of course also greatly simplifies our parsing code and also gets rid of a few tests that now became obsolete. Signed-off-by: aszlig <aszlig@nix.build>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already introduced deprecation warnings back in 49b889b, telling people that we're going to
remove YAML in version 3.0.
With this, the removal is essentially done and we now no longer depend on
yaml-cpp, nor do we needpkg-configor anything like that, because we essentially have zero (external) library dependencies exceptlibcandlibdl.This of course also greatly simplifies our parsing code and also gets rid of a few tests that now became obsolete.